Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Not sure how to avoid. I think it was two things:

1. Some devs just didn't like having review discussions as PR comments. Maybe it's the way that the threads break up the markdown source. Or maybe WYSIWYG feels better for doc review. I also recall people saying "it's hard to know what's changed, could you add a changelog section?" When I replied "it's a git repo, and I leave detailed commit messages," there was no response. I think this means that they don't like that.

2. The managers who decide things don't use git. We use Google Docs for everything else, why not for this?

In the end, Google Docs works well enough. I do miss the commit log, though. It's tricky to link to a previous revision in the changelog table -- maybe I'll get into the habit of it.

Both GitHub PRs and Google Docs have this problem, though: There's no ready record of the review process -- the comments. They eventually disappear and are difficult or impossible to retrieve, and they lose context.

Not like anybody is bothering to dig.



> There's no ready record of the review process -- the comments. They eventually disappear

I wonder if someone could build something clever with git-notes [0] to capture such discussions in the repo itself.

I'm sure others have thought about it already, so there must be some kind of pitfall... A little more searching finds projects like git-appraise. [1]

[0] https://git-scm.com/docs/git-notes

[1] https://github.com/google/git-appraise


What about a wiki, like xwiki or others ? They have diff for changes (changelo), comments and in inline @user prompts.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: